chore: update escargot with bug fix #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is it still valid PR? |
|
@haesik it's still in progress, I'll update it as soon as faster. |
thanks for the info |
clover2123
force-pushed
the
pr
branch
3 times, most recently
from
b038175
to
2bcfa86
Compare
clover2123
force-pushed
the
pr
branch
3 times, most recently
from
2d328fa
to
8563d27
Compare
* update the latest escargot and walrus module * fix misc bugs related with escargot update * use ESCARGOT_USE_EXTENDED_API and relevant APIs Signed-off-by: HyukWoo Park <[email protected]>
clover2123
changed the title
clover2123
commented
May 14, 2024
| @@ -47,6 +47,7 @@ | |||
| 'escargot_configs': [ | |||
| '-DESCARGOT_SMALL_CONFIG=1', | |||
| '-DESCARGOT_USE_CUSTOM_LOGGING=ON', | |||
| '-DESCARGOT_USE_EXTENDED_API=ON', | |||
There was a problem hiding this comment.
Escargot build option updated.
To use specific non-standard features of Escargot like Template, build option ESCARGOT_USE_EXTENDED_API should be set ON.
clover2123
commented
May 14, 2024
Comment on lines
+197
to
+199
| test/parallel/test-worker-stack-overflow.js | ||
| test/parallel/test-worker-stdio.js # CI 테스트중 간헐적으로 crash. 타이밍 이슈로 추정됨 | ||
| test/parallel/test-worker-stdio-from-preload-module.js # occasionally crashed in CI, might be timing issue |
There was a problem hiding this comment.
Several tests failed occasionally in CI.
But when I run these tests on my local environment, it passed.
I think that this is related with timing issue as these tests all employ worker method.
daeyeon
approved these changes
May 14, 2024
hs0225
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.