Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape source path in VSCode protocol output event #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tbrauredev
Copy link

Fixes #175

Tested on Windows through nvim-dap with a .Net Core Web API template project, test suite is also still passing on Windows.

@viewizard
Copy link
Member

Thanks! Looks good to me. I moved this PR into internal dev repo, all CI tests are passed. Will be merged into internal dev repo and will appear in public repo after next repo sync.

@dkattan
Copy link

dkattan commented Sep 25, 2024

I'd love to see this get merged in as well. I'm getting a ton of these errors

Copy link
Member

@gbalykov gbalykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This change is already merged in internal dev repo, will be available in upstream on next repo sync.

@dkattan
Copy link

dkattan commented Oct 3, 2024

Thanks for your contribution! This change is already merged in internal dev repo, will be available in upstream on next repo sync.

Any idea when that will be?

@gbalykov
Copy link
Member

gbalykov commented Oct 4, 2024

Any idea when that will be?

Next release will be in October and will include fixes for other issues too.

@dkattan
Copy link

dkattan commented Oct 4, 2024

Any idea when that will be?

Next release will be in October and will include fixes for other issues too.

Just want to say I appreciate that this project exists. Despite this issue it works great for Debugging C# in Cursor AI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unescaped source path in JSON body of DAP output event causes errors in nvim-dap
5 participants