Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pngquant got a breaking change #1426

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Pngquant got a breaking change #1426

merged 1 commit into from
Oct 11, 2021

Conversation

cyrille-sg
Copy link
Contributor

@cyrille-sg cyrille-sg commented Oct 8, 2021

Forcing resolution for now to make it pass imagemin/imagemin-pngquant#46

Forcing resolution will froze the version. As a side effect, any vulnerability fix will not be installed.
Alternative is to add the apt buildpack and install the libpng-dev

@EtienneM
Copy link
Member

EtienneM commented Oct 8, 2021

in ubuntu 20 it will be resolved with the package installed

scalingo-20 is released in prod, don't you want to set it for the documentation if it solves the issue?

@cyrille-sg
Copy link
Contributor Author

Oh, was not aware of that. Will give a try

@cyrille-sg
Copy link
Contributor Author

cyrille-sg commented Oct 8, 2021

It is not working, as it seems our ubuntu-20 does not onboard the lib png

@cyrille-sg cyrille-sg merged commit 4e18e26 into master Oct 11, 2021
@cyrille-sg cyrille-sg deleted the fix/pngquant-bc branch October 11, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants