Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symlink support #27

Closed
wants to merge 4 commits into from
Closed

Add symlink support #27

wants to merge 4 commits into from

Conversation

Jupi007
Copy link
Contributor

@Jupi007 Jupi007 commented Dec 1, 2022

  • todo: update readme.md
  • todo: add check for missing target icon

Usage

Create a symlinks file

For an existent icon target.svg:

{
    "symlink": "target"
}

Symlink is placed as key to avoid duplicate entries.
And like this, we can create different symlink of a target.

Run cli

icon_font_generator --symlinks-map=path/to/symlinks.json ...

Error messages

If the symlink name already exist (as an existent icon or just as a symlink):

Warning: symlink "symlink" icon already exists - symlink creation skipped

If the target icon is a symlink:

Warning: target "target" icon is already a symlink - symlink creation skipped

If the target icon does not exist:

Warning: target "target" icon does not exist - symlink creation skipped

Result

static const target = _IconsData(0xf101, 'target');
static const symlink = _IconsData(0xf101, 'symlink');

Closes #26

@Jupi007 Jupi007 marked this pull request as draft December 1, 2022 18:16
@Jupi007
Copy link
Contributor Author

Jupi007 commented Aug 16, 2023

Closing, I will redo another PR updated with the most recent changes in master later.

@Jupi007 Jupi007 closed this Aug 16, 2023
@Jupi007 Jupi007 deleted the symlink branch December 19, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add symlink support
1 participant