-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ReadOnlyArray
from type parameters
#301
Comments
This was referenced Jul 22, 2024
That sounds reasonable. Indeed array wrappers always tend to introduce other problems. I think one other I saw was GPU support. |
visr
added a commit
to Deltares/Ribasim
that referenced
this issue
Jul 28, 2024
Fixes #1625. Some upstream issues came out of this: SciML/DataInterpolations.jl#301 SciML/DataInterpolations.jl#302 SciML/DataInterpolations.jl#303 --------- Co-authored-by: Martijn Visser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I want to hardcode the concrete type of an interpolation object as a field of a struct. In my opinion it shouldn't be required to have
ReadOnlyArrays
as an explicit dependency of my package to do this. I start to like this wrapper less and less 🙃Maybe a good way forward is to get rid of this wrapper, make caching parameters opt-in and properly document that if you do this you should not update
u, t
. This has the advantage that the default setting is more compatible with AD packages. Then we should only make sure that AD packages do not try to differentiate w.r.t. cached parameters.The text was updated successfully, but these errors were encountered: