Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all perceived/cyclomatic complexity rubocop offences #116

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

Prakriti-nith
Copy link
Contributor

Partially fixes #66.

@coveralls
Copy link

coveralls commented Aug 2, 2018

Pull Request Test Coverage Report for Build 667

  • 8 of 15 (53.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 97.925%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/daru/view/adapters/googlecharts.rb 7 9 77.78%
lib/daru/view/adapters/highcharts/layout_helper_iruby.rb 1 6 16.67%
Totals Coverage Status
Change from base Build 664: -0.09%
Covered Lines: 3114
Relevant Lines: 3180

💛 - Coveralls

@Prakriti-nith
Copy link
Contributor Author

@Shekharrajak can you please review this PR too?

Copy link
Member

@Shekharrajak Shekharrajak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me.

@Shekharrajak Shekharrajak merged commit 9d19aed into SciRuby:master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve code quality
3 participants