Improve coverage for googlecharts.rb file #80
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for the issue #67.
Tests were already present for an empty array being passed to the
data
parameter.Adding tests when a vector is passed as
data
.It also improves coverage for the method add_vector_data: https:/SciRuby/daru-view/blob/master/lib/daru/view/adapters/googlecharts.rb#L154-L160.
I also wanted to add tests for the method return_js_type: https:/SciRuby/daru-view/blob/master/lib/daru/view/adapters/googlecharts.rb#L173-#L188.
I have tried testing it as:
it "when data is of class type String" do expect(Daru::View::Adapter::GooglechartsAdapter.return_js_type("daru")).to eq "string" end
But as this method is a private method and it is recommended not to test the private methods, is it possible if we could test it using ruby's send method?