Update ToLLamaSharpChatHistory extension method to be public and support semantic-kernel author roles #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort semantic-kernel author roles
AsakusaRinne
requested changes
Nov 11, 2023
| { | ||
| internal static global::LLama.Common.ChatHistory ToLLamaSharpChatHistory(this ChatHistory chatHistory) | ||
| public static global::LLama.Common.ChatHistory ToLLamaSharpChatHistory(this ChatHistory chatHistory) |
There was a problem hiding this comment.
I think adding a parameter bool ignoreCase = true to allow control on it will be better.
There was a problem hiding this comment.
Makes sense to me, just added the parameter.
Thank you for the awesome library! This is actually my first contribution to an open source project 😄
There was a problem hiding this comment.
You're always welcome! I'm happy that our work makes sense to you. If you're interested in developing this library, there's a TODO list in LLamaSharp project. 😊
There was a problem hiding this comment.
Sure, I'd love to help! It looks like the project board is set to private though, I'm getting a 404 error
There was a problem hiding this comment.
Sorry for that, I've now changed it to public. :)
AsakusaRinne
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when semantic-kernel ChatHistory is converted to LLamaSharp ChatHistory through the ToLLamaSharpChatHistory extension method in https:/SciSharp/LLamaSharp/blob/master/LLama.SemanticKernel/ExtensionMethods.cs the AuthorRole in the resulting LLamaSharp ChatHistory is set to AuthorRoles.Unknown as semantic-kernel uses lowercase author names while LLamaSharp capitalizes the first character. This PR tells the Enum.TryParse method to ignore letter case when matching.
Further, it exposes the ToLLamaSharpChatHistory extension method publicly since it would be useful for debugging in downstream applications.