Add Rosetta2 Binaries #755
Conversation
@abhiaagarwal, it seems that the step to Gather binaries fail in linked execution. I would appreciate If you can check this. The other thing that seems strange to me is to name this as something related with rosetta. Any intel osx without avx support is included in this use case (including rosetta emulation). Am I right or I'm missing something?. |
|
I'll fix the issue! Missing adding the folder name in
Yes, but at least in regards to Macbooks on Intel, non-AVX hardware doesn't really exist anymore. I did a search and the last chip in an Intel Macbook was in 2014. I named it Rosetta2 to make it more clear to anyone poking around why these binaries exist, but I don't really have a strong opinion otherwise. More than happy to rename it to |
|
@abhiaagarwal Could you start another test run on your repo please. If that works we can merge this :) |
|
@martindevans absolutely! Fixed the mkdir issue and triggered a new run here. https:/abhiaagarwal/LLamaSharp/actions/runs/9294309458 |
|
Seems like the hardest thing I've ever done is properly creating directories... here's a run that succeeded. https:/abhiaagarwal/LLamaSharp/actions/runs/9294794909 |
|
There's one more thing: could you please add the binaries to this nuspec file, so that it will get published in our next release? Besides, @martindevans @SignalRT do you think it's a good idea to separate the MAC backend package from |
Seems like a good idea to me, it's a good way to shrink the CPU backend package down a bit. |
|
If you can open a new branch on this repo, I can change this PR to merge against that? I'm not familiar with dotnet packaging, but a mac-specific backend is for sure a good idea. |
|
The PR it's ok for me. I would not separate the backend at this moment. In my opinion the point that rest is to add de libraries to the nuspec |
|
Updated the nuspec. Do y'all want me to squash my commits? |
|
No need for you to squash, we can squash-and-merge :) |
Closes #752. I make the assumption that "if x86 and doesn't have AVX, then it is rosetta2". My understanding is that all modern (>2015)-based Intel CPUs used on Macbooks have AVX, so checking for AVX under a x86 environment is a good enough proxy for "under Rosetta2".