Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: the directory structure. #763

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AsakusaRinne
Copy link
Collaborator

Despite so many changes, this PR simply does the following things.

  • Move the projects to three folders (src, test, samples) in both file system level and .NET solution level.
  • Correct the file paths in the documentation and workflows.

Since we'll add the code generation (#738) and split the package into different levels, the number of projects will increase. Moving the projects to different folders will make the structure more clear. Besides, it's better to allow multiple projects for our example, making it more flexible.

@AsakusaRinne AsakusaRinne added break change ci/cd benchmark Trigger benchmark workflow labels May 28, 2024
@martindevans
Copy link
Member

martindevans commented May 28, 2024

Looks good. Only concern is this will probably break every other pending PR. Should we make an effort to get every other PR either closed or merged first?

Several PRs are quite stale, so it'd be good to get them cleared up anyway.

@AsakusaRinne
Copy link
Collaborator Author

Agreed. Is #751 expected to be merged soon?

@martindevans
Copy link
Member

It's had some testing on every platform, we could probably merge it right now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Trigger benchmark workflow break change ci/cd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants