Demo Numpy v2 #6035
Draft
Demo Numpy v2 #6035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
benchmark_this
trexfeathers
added a commit
to trexfeathers/iris
that referenced
this pull request
Jul 2, 2024
bjlittle
pushed a commit
that referenced
this pull request
Jul 3, 2024
* NEP29 NumPy pin. * Pin back from NumPy v2 (#6035). * PyPI pins.
…cale_factor_add_offset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
We already know that Iris' syntax is NumPy v2 compliant, thanks to Ruff, but that does not prove that the code will all function with NumPy v2.
A vanilla Conda install of Iris does get NumPy v2, but unfortunately our full test environment does not (some of the dependencies must be pinned). So I have forced the issue by manually editing
requirements/locks/py312-linux-64.lock, which does thankfully produce a working environment since none of NumPy's dependencies have changed.The test failures show us what work we need to do for Iris to be compliant with NumPy v2. It seems to mostly be around changes in:
dtypesConsult Iris pull request check list
Add any of the below labels to trigger actions on this PR: