Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of scalars in NetCDFTimeConverter.convert #46

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

spencerkclark
Copy link
Member

This provides a simple fix for #45.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.228% when pulling 8c9362f on spencerkclark:convert-scalar into 531dd0d on SciTools:master.

@bjlittle bjlittle self-assigned this Jun 8, 2021
@bjlittle bjlittle added this to the v1.3.0 milestone Jun 8, 2021
@rcomer rcomer linked an issue Jun 8, 2021 that may be closed by this pull request
@bjlittle
Copy link
Member

bjlittle commented Jun 9, 2021

@spencerkclark Once #66 lands (hopefully), you'll need to rebase, then I'll review and merge 👍

@bjlittle
Copy link
Member

@spencerkclark Time to rebase 👍

Then let's get this finally banked 😃

@codecov-commenter
Copy link

Codecov Report

Merging #46 (fe10e4c) into master (865dc22) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   89.14%   89.08%   -0.07%     
==========================================
  Files           1        1              
  Lines         175      174       -1     
  Branches       42       42              
==========================================
- Hits          156      155       -1     
  Misses         13       13              
  Partials        6        6              
Impacted Files Coverage Δ
nc_time_axis/__init__.py 89.08% <100.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865dc22...fe10e4c. Read the comment docs.

@spencerkclark
Copy link
Member Author

Awesome, should be all set @bjlittle -- I also removed an errant print statement that seemed to have crept in during #66.

@bjlittle
Copy link
Member

I'll get to this, this evening 👍

Awesome!

@bjlittle bjlittle merged commit 8bdb8da into SciTools:master Jun 10, 2021
@bjlittle
Copy link
Member

@spencerkclark Perfect, thanks 🍻

@spencerkclark spencerkclark deleted the convert-scalar branch June 10, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the way NetCDFTimeConverter.convert handles scalars
4 participants