[Screenshot Generator] Add explicit Toast duration, additional code comments
#613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdmukai
added a commit
to kdmukai/seedsigner
that referenced
this pull request
Sep 21, 2024
I instead submitted them as a PR to the main repo's `dev` branch: SeedSigner#613
|
Viewed code changes, which I like, but have not yet tested. |
|
Looks neat @kdmukai! I noticed this behavior in test case while developing PR #600. From what I understand, setting it to 0 in the test cases, or potentially a different value in future developments, seems like a solid approach, so ACK for me. I will update that PR to prevent conflicts if this one gets merged, as I also have changes in this file: https:/SeedSigner/seedsigner/pull/600/files#diff-887aac80585a20b298dabebe9d8fc3b36151a83b79f30c963f79f1585dae96e2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Light refactor of
RemoveSDCardToastManagerThreadto give the screenshot generator more explicit control over that Toast.Screenshot generator now sets
RemoveSDCardToastManagerThread.duration=0to guarantee that the "infinite" Toast would never block during the screenshot generation. It was succeeding (not blocking) before becauseMicroSD.is_insertedchecksSettings.HOSTNAME == Settings.SEEDSIGNER_OS, but this took too much digging to understand that Toast's behavior in the screenshot generator.How the Toast screenshots are rendered at all is quite confusing so additional step-by-step explanatory comments were added.
This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os: