Forward rest parameters to model #1921
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idlefella
changed the title
sakoush
reviewed
Oct 16, 2024
Comment on lines
+199
to
+202
| params = None | ||
| if payload.parameters and payload.parameters.model_extra: | ||
| params = payload.parameters.model_extra | ||
| model_output = self._model.predict(decoded_payload, params=params) |
There was a problem hiding this comment.
is there a test that can be added for this new functionality @idlefella ?
There was a problem hiding this comment.
@idlefella I think params is only supported for class-based pyfunc models and therefore this proposed changed will not work for function-based models.
I think we need to find a way to check the type of the model loaded and not pass params for function-based models.
check here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Fixes #1660
Description
The parameters sent over REST to the mlserver are not forwarded to the predict function of the model. This PR fixes that issue.
Changes Made
Properly forward the params to the predict function of the model.
Related Issues
Screenshots (if applicable)
Checklist
Additional Notes