added setting to disable automatic strigify of pdo mysql #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roshanbudhathoki seems like some Unit tests are failing after the change. Could you pls review? |
|
@develart-projects I am getting following error. Testing fetchLatersVersion only works when TESTS_ZEND_VERSION_ONLINE_ENABLED is set. Am I missing to setup something. Even unsure where do I setup this. |
|
@roshanbudhathoki here is my local testing command: |
develart-projects
added
the
requested change
|
@develart-projects I have fixed and updated the code, should work now. Please approve so that CI can run and give us the test results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #362 as prescribed by
hungtrinh