LoadedFeaturesIndex#register: Ignore absolute paths entirely #385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #383
Ref: fxn/zeitwerk#198
The loaded feature index goal is to prevent requiring the same "feature" twice if the
$LOAD_PATH
was mutated. e.g:In such scenario Ruby remember that you require "bundler" already and even though it now maps to a new path, it won't load it again.
This was causing issues with Zeitwerk if it is loaded before bootsnap (see refs), because the cache wouldn't be cleared.
But ultimately Zeitwerk always require absolute paths, and the concern described above simply doesn't apply to absolute paths. So we can simply bail out early in these cases. That fixes the bug, and also means less work and a smaller index, so win-win.
cc @fxn