Use a .ruby-version #101
Merged
Use a .ruby-version #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshenny
reviewed
Mar 22, 2024
There was a problem hiding this comment.
LGTM! Can you remove this line too? https:/Shopify/deprecation_toolkit/blob/main/.rubocop.yml#L5
|
+1 to removing the |
etiennebarrie
force-pushed
the
centralize_ruby_version
branch
from
a2c72c6
to
74cafea
Compare
|
Good catch, I missed it even though I had used your script 🤦 |
jenshenny
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to standardize on using .ruby-version, this bumps Rubocop (we need 1.61 that pulls the target ruby version from the gemspec).
To update Rubocop I had to update rubocop-shopify and fix the style. I changed some objects that were classes to be modules extending themselves, instead of defining the method on the singleton class. This includes all the Behavior objects and some test objects. I don't think this is an issue since users were encouraged to use the existing behaviors or create their own, but no subclassing was required.
I also dropped support for Ruby 2.7 which has been EOL for almost a year, and found a code path for Active Support < 5 which I've also removed.