Remove deprecated CLI flags #2603
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
rbshop
commented
Oct 14, 2024
| @@ -82,7 +81,7 @@ export default class Deploy extends Command { | |||
| }), | |||
| preview: Flags.boolean({ | |||
| description: | |||
| 'Deploys to the Preview environment. Overrides --env-branch and Git metadata.', | |||
| 'Deploys to the Preview environment. Overrides Git metadata.', | |||
There was a problem hiding this comment.
This previously stated that it Overrides --env-branch, but looking at the original code in this file a little further down it appears that this wasn't actually the case (and I think we should also remove the claim that this overrides the Git metadata too?)
rbshop
commented
Oct 14, 2024
| @@ -357,10 +354,6 @@ export async function runDeploy( | |||
| ); | |||
| } | |||
|
|
|||
| if (isCI && envBranch) { | |||
There was a problem hiding this comment.
This was added in #2281, with the note:
Future task
envflag will require more effort as it needs to be available on our dependant services
the current fix only patches it for theenvBranchflag
Do we still want this feature? Is that future work tracked anywhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Both flags have been deprecated for a while and are due to be removed with the next release
WHAT is this pull request doing?
--workerflag--env-branchflag and associated codeChecklist