Fix the killing of processes in monorepo #450
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #443, we added a
-k
to thedev
script in our demo-store. @frandiox probably knows why for sure, but my guess is that we wanted to prevent stray processes from running when one of them fails.This works fine when you're running
npm run dev
from within the demo-store template itself! BUT: when you run it as part of theturbo
monorepodev
command, shit breaks with no real error. I'm guessing this is related to a false positive withinconcurrently
, perhaps due to turbo or due to the preceding&&
command.https:/open-cli-tools/concurrently#usage
Anyway, this seems to fix it.