Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
### WHAT is this pull request doing? This PR upgrades `stylelint-polaris` to `stylelint` v16 and drops support for v15 and v16. As part of this upgrade, the following updates were made: - Upgraded dependencies - `stylelint` to `^16.6.1` - `stylelint-scss` to `^6.3.2` - `@shopify/eslint-plugin` to `^45.0.0` - `@shopify/stylelint-plugin` to `^14.0.0` - `eslint` to `^8.56.0` - `jest-preset-stylelint` to `^7.0.1` - `prettier` to `^3.2.2` - Patched `stylelint` to report errors on async rules. See Stylelint issue for more details: stylelint/stylelint#7820 - Added `--experimental-vm-modules` flag to `jest` calls to enable support for async plugins - Updated relevant `stylelint-polaris` plugins and `stylelint` APIs to be asynchronous - Updated `prettier.format` calls to be asynchronous - Resolved `eslint` and `stylelint` failures after dependency upgrades - Temporarily removed the `styles-insert-stylelint-disable` migration as `result.messages` `node`s are now detached from the `root` AST. Calls such as `node.prev()` and `node.before(comment)` now throw exceptions as the reported nodes don't have access to properties and methods previously exposed. The consensus speaking with @kyledurand and @sophschneider is that we can revisit adding support for this migration if and when it is needed again. ### How to 🎩 🖥 [Local development instructions](https:/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https:/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https:/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested a [snapshot](https:/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [ ] Tested on [mobile](https:/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https:/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https:/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Jess Telford <[email protected]> Co-authored-by: Kyle Durand <[email protected]>
- Loading branch information