Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing image for card layout patterns #11909

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

sarahill
Copy link
Contributor

before after
Screenshot 2024-04-18 at 12 22 33 PM Screenshot 2024-04-18 at 12 21 30 PM

@sarahill sarahill added the Bug Something is broken and not working as intended in the system. label Apr 18, 2024
@sarahill sarahill self-assigned this Apr 18, 2024
@sarahill sarahill merged commit c4f766f into main Apr 18, 2024
11 checks passed
@sarahill sarahill deleted the fix-card-patterns-image branch April 18, 2024 20:07
kyledurand pushed a commit that referenced this pull request Apr 19, 2024
This PR was opened by the [Changesets
release](https:/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/[email protected]

### Patch Changes

- [#11915](#11915)
[`828995cc4`](828995c)
Thanks [@kyledurand](https:/kyledurand)! - Fixed Picker
empty state


- [#11918](#11918)
[`fd37c1896`](fd37c18)
Thanks [@kyledurand](https:/kyledurand)! - Reverted selected
icon placement on Option and TextOption

## [email protected]

### Patch Changes

- [#11906](#11906)
[`5b9f4b898`](5b9f4b8)
Thanks [@sarahill](https:/sarahill)! - Updated common action
pattern add guiance


- [#11909](#11909)
[`c4f766f1d`](c4f766f)
Thanks [@sarahill](https:/sarahill)! - Fixed missing image
for card layout pattern documentation

- Updated dependencies
\[[`828995cc4`](828995c),
[`fd37c1896`](fd37c18)]:
    -   @shopify/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants