Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use clickhouse.ParseDSN for URL parsing #26

Merged
merged 1 commit into from
Apr 24, 2024
Merged

chore: use clickhouse.ParseDSN for URL parsing #26

merged 1 commit into from
Apr 24, 2024

Conversation

prashant-shahi
Copy link
Member

Before:

remote_read:
  - url: tcp://clickhouse:9000?database=db_name&username=user&password=passwd

After:

remote_read:
  - url: tcp://user:passwd@clickhouse:9000/db_name

Signed-off-by: Prashant Shahi [email protected]

@prashant-shahi prashant-shahi merged commit fc8a851 into signoz/main Apr 24, 2024
17 of 33 checks passed
@prashant-shahi prashant-shahi deleted the chore/clickhouse-dns branch April 24, 2024 19:35
@prashant-shahi prashant-shahi mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prashant-shahi @srikanthccv