-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use --cluster instead of --cluster-name in migrator command flag #308
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the otel collector is using the
--cluster-name
to pass the ClickHouse name, but the signoz query component is using--cluster
. See:[1] https:/SigNoz/signoz-otel-collector/blob/main/cmd/signozschemamigrator/migrate.go#L41
[2] https:/SigNoz/signoz/blob/develop/pkg/query-service/main.go#L54
Not sure if it sounds good to add an extra
--cluster
to keep consistent with the query component, or add an extra option--cluster-name
in the query component?I will be happy to submit a PR to resolve this if it sounds good.
The text was updated successfully, but these errors were encountered: