Skip to content

Commit

Permalink
chore: fix lint errors
Browse files Browse the repository at this point in the history
  • Loading branch information
YounixM committed Jul 16, 2024
1 parent 91e20e9 commit 91c081b
Show file tree
Hide file tree
Showing 11 changed files with 42 additions and 42 deletions.
7 changes: 3 additions & 4 deletions frontend/src/container/AllError/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { ColumnType, TablePaginationConfig } from 'antd/es/table';
import { FilterValue, SorterResult } from 'antd/es/table/interface';
import { ColumnsType } from 'antd/lib/table';
import { FilterConfirmProps } from 'antd/lib/table/interface';
import logEvent from 'api/common/logEvent';
import getAll from 'api/errors/getAll';
import getErrorCounts from 'api/errors/getErrorCounts';
import { ResizeTable } from 'components/ResizeTable';
Expand All @@ -23,7 +24,8 @@ import { convertRawQueriesToTraceSelectedTags } from 'hooks/useResourceAttribute
import useUrlQuery from 'hooks/useUrlQuery';
import createQueryParams from 'lib/createQueryParams';
import history from 'lib/history';
import { useCallback, useEffect, useMemo } from 'react';
import { isUndefined } from 'lodash-es';
import { useCallback, useEffect, useMemo, useRef } from 'react';
import { useTranslation } from 'react-i18next';
import { useQueries } from 'react-query';
import { useSelector } from 'react-redux';
Expand All @@ -32,9 +34,6 @@ import { AppState } from 'store/reducers';
import { ErrorResponse, SuccessResponse } from 'types/api';
import { Exception, PayloadProps } from 'types/api/errors/getAll';
import { GlobalReducer } from 'types/reducer/globalTime';
import { isUndefined } from 'lodash-es';
import { useRef } from 'react';
import logEvent from 'api/common/logEvent';

import { FilterDropdownExtendsProps } from './types';
import {
Expand Down
10 changes: 5 additions & 5 deletions frontend/src/container/ErrorDetails/index.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import './styles.scss';

import { Button, Divider, Space, Typography } from 'antd';
import logEvent from 'api/common/logEvent';
import getNextPrevId from 'api/errors/getNextPrevId';
import Editor from 'components/Editor';
import { ResizeTable } from 'components/ResizeTable';
Expand All @@ -9,15 +10,13 @@ import dayjs from 'dayjs';
import { useNotifications } from 'hooks/useNotifications';
import createQueryParams from 'lib/createQueryParams';
import history from 'lib/history';
import { isUndefined } from 'lodash-es';
import { urlKey } from 'pages/ErrorDetails/utils';
import { useMemo, useState } from 'react';
import { useEffect, useMemo, useRef, useState } from 'react';
import { useTranslation } from 'react-i18next';
import { useQuery } from 'react-query';
import { useLocation } from 'react-router-dom';
import { PayloadProps as GetByErrorTypeAndServicePayload } from 'types/api/errors/getByErrorTypeAndService';
import { isUndefined } from 'lodash-es';
import logEvent from 'api/common/logEvent';
import { useEffect, useRef } from 'react';

import { keyToExclude } from './config';
import { DashedContainer, EditorContainer, EventContainer } from './styles';
Expand Down Expand Up @@ -130,10 +129,11 @@ function ErrorDetails(props: ErrorDetailsProps): JSX.Element {
groupId: errorDetail.groupID,
spanId: errorDetail.spanID,
traceId: errorDetail.traceID,
exceptionId: errorDetail.errorId
exceptionId: errorDetail.errorId,
});
logEventCalledRef.current = true;
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [data]);

return (
Expand Down
3 changes: 1 addition & 2 deletions frontend/src/container/ListOfDashboard/ImportJSON/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { ExclamationCircleTwoTone } from '@ant-design/icons';
import MEditor, { Monaco } from '@monaco-editor/react';
import { Color } from '@signozhq/design-tokens';
import { Button, Modal, Space, Typography, Upload, UploadProps } from 'antd';
import logEvent from 'api/common/logEvent';
import createDashboard from 'api/dashboard/create';
import ROUTES from 'constants/routes';
import { useIsDarkMode } from 'hooks/useDarkMode';
Expand All @@ -18,8 +19,6 @@ import { useTranslation } from 'react-i18next';
import { generatePath } from 'react-router-dom';
import { DashboardData } from 'types/api/dashboard/getAll';

import logEvent from 'api/common/logEvent';

function ImportJSON({
isImportJSONModalVisible,
uploadedGrafana,
Expand Down
9 changes: 4 additions & 5 deletions frontend/src/container/MetricsApplication/Tabs/DBCall.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Col } from 'antd';
import logEvent from 'api/common/logEvent';
import { ENTITY_VERSION_V4 } from 'constants/app';
import { PANEL_TYPES } from 'constants/queryBuilder';
import Graph from 'container/GridCardLayout/GridCard';
Expand All @@ -11,16 +12,12 @@ import {
convertRawQueriesToTraceSelectedTags,
resourceAttributesToTagFilterItems,
} from 'hooks/useResourceAttribute/utils';
import { useMemo, useState } from 'react';
import { useEffect, useMemo, useRef, useState } from 'react';
import { useParams } from 'react-router-dom';
import { TagFilterItem } from 'types/api/queryBuilder/queryBuilderData';
import { EQueryType } from 'types/common/dashboard';
import { v4 as uuid } from 'uuid';

import { isUndefined } from 'lodash-es';
import { useRef, useEffect } from 'react';
import logEvent from 'api/common/logEvent';

import { GraphTitle, MENU_ITEMS, SERVICE_CHART_ID } from '../constant';
import { getWidgetQueryBuilder } from '../MetricsApplication.factory';
import { Card, GraphContainer, Row } from '../styles';
Expand Down Expand Up @@ -102,6 +99,7 @@ function DBCall(): JSX.Element {
);

const logEventCalledRef = useRef(false);

useEffect(() => {
if (!logEventCalledRef.current) {
const selectedEnvironment = queries.map((val) => {
Expand All @@ -116,6 +114,7 @@ function DBCall(): JSX.Element {
});
logEventCalledRef.current = true;
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);

const apmToTraceQuery = useGetAPMToTracesQueries({
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/container/MetricsApplication/Tabs/External.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Col } from 'antd';
import logEvent from 'api/common/logEvent';
import { ENTITY_VERSION_V4 } from 'constants/app';
import { PANEL_TYPES } from 'constants/queryBuilder';
import Graph from 'container/GridCardLayout/GridCard';
Expand All @@ -13,7 +14,7 @@ import {
convertRawQueriesToTraceSelectedTags,
resourceAttributesToTagFilterItems,
} from 'hooks/useResourceAttribute/utils';
import { useMemo, useState } from 'react';
import { useEffect, useMemo, useRef, useState } from 'react';
import { useParams } from 'react-router-dom';
import { DataTypes } from 'types/api/queryBuilder/queryAutocompleteResponse';
import { EQueryType } from 'types/common/dashboard';
Expand All @@ -30,8 +31,6 @@ import {
onViewTracePopupClick,
useGetAPMToTracesQueries,
} from './util';
import { useRef, useEffect } from 'react';
import logEvent from 'api/common/logEvent';

function External(): JSX.Element {
const [selectedTimeStamp, setSelectedTimeStamp] = useState<number>(0);
Expand Down Expand Up @@ -131,6 +130,7 @@ function External(): JSX.Element {
});
logEventCalledRef.current = true;
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);

const externalCallRPSWidget = useMemo(
Expand Down
7 changes: 3 additions & 4 deletions frontend/src/container/MetricsApplication/Tabs/Overview.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import logEvent from 'api/common/logEvent';
import getTopLevelOperations, {
ServiceDataProps,
} from 'api/metrics/getTopLevelOperations';
Expand All @@ -17,7 +18,7 @@ import useUrlQuery from 'hooks/useUrlQuery';
import history from 'lib/history';
import { OnClickPluginOpts } from 'lib/uPlotLib/plugins/onClickPlugin';
import { defaultTo } from 'lodash-es';
import { useCallback, useMemo, useState } from 'react';
import { useCallback, useEffect, useMemo, useRef, useState } from 'react';
import { useQuery } from 'react-query';
import { useDispatch } from 'react-redux';
import { useLocation, useParams } from 'react-router-dom';
Expand Down Expand Up @@ -47,9 +48,6 @@ import {
onViewTracePopupClick,
useGetAPMToTracesQueries,
} from './util';
import { isUndefined } from 'lodash-es';
import { useRef, useEffect } from 'react';
import logEvent from 'api/common/logEvent';

function Application(): JSX.Element {
const { servicename: encodedServiceName } = useParams<IServiceName>();
Expand Down Expand Up @@ -99,6 +97,7 @@ function Application(): JSX.Element {
});
logEventCalledRef.current = true;
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);

const {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,19 @@ import './styles.scss';
import { ExclamationCircleOutlined, PlusOutlined } from '@ant-design/icons';
import { Card, Modal, Table, Typography } from 'antd';
import { ExpandableConfig } from 'antd/es/table/interface';
import logEvent from 'api/common/logEvent';
import savePipeline from 'api/pipeline/post';
import useAnalytics from 'hooks/analytics/useAnalytics';
import { useNotifications } from 'hooks/useNotifications';
import { isUndefined } from 'lodash-es';
import cloneDeep from 'lodash-es/cloneDeep';
import React, { useCallback, useMemo, useState } from 'react';
import React, {
useCallback,
useEffect,
useMemo,
useRef,
useState,
} from 'react';
import { DndProvider } from 'react-dnd';
import { HTML5Backend } from 'react-dnd-html5-backend';
import { useTranslation } from 'react-i18next';
Expand Down Expand Up @@ -46,10 +54,6 @@ import {
getTableColumn,
getUpdatedRow,
} from './utils';
import { isUndefined } from 'lodash-es';

import { useRef, useEffect } from 'react';
import logEvent from 'api/common/logEvent';

function PipelinesListEmptyState(): JSX.Element {
const { t } = useTranslation(['pipeline']);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
import localStorageGet from 'api/browser/localstorage/get';
import localStorageSet from 'api/browser/localstorage/set';
import logEvent from 'api/common/logEvent';
import { SKIP_ONBOARDING } from 'constants/onboarding';
import useErrorNotification from 'hooks/useErrorNotification';
import { useQueryService } from 'hooks/useQueryService';
import useResourceAttribute from 'hooks/useResourceAttribute';
import { convertRawQueriesToTraceSelectedTags } from 'hooks/useResourceAttribute/utils';
import { useMemo, useState } from 'react';
import { isUndefined } from 'lodash-es';
import { useEffect, useMemo, useRef, useState } from 'react';
import { useSelector } from 'react-redux';
import { AppState } from 'store/reducers';
import { GlobalReducer } from 'types/reducer/globalTime';
import { Tags } from 'types/reducer/trace';

import { isUndefined } from 'lodash-es';
import { useRef, useEffect } from 'react';
import logEvent from 'api/common/logEvent';

import SkipOnBoardingModal from '../SkipOnBoardModal';
import ServiceTraceTable from './ServiceTracesTable';

Expand Down Expand Up @@ -65,10 +63,11 @@ function ServiceTraces(): JSX.Element {
numberOfServices: data?.length,
selectedEnvironment: selectedEnvironment?.[0]?.[0],
resourceAttributeUsed: !!queries.length,
rps: rps,
rps,
});
logEventCalledRef.current = true;
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [data]);

if (
Expand Down
4 changes: 3 additions & 1 deletion frontend/src/container/SideNav/SideNav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import './SideNav.styles.scss';

import { Color } from '@signozhq/design-tokens';
import { Button, Tooltip } from 'antd';
import logEvent from 'api/common/logEvent';
import cx from 'classnames';
import { FeatureKeys } from 'constants/features';
import ROUTES from 'constants/routes';
Expand Down Expand Up @@ -44,7 +45,7 @@ import defaultMenuItems, {
import NavItem from './NavItem/NavItem';
import { SecondaryMenuItemKey, SidebarItem } from './sideNav.types';
import { getActiveMenuKeyFromPath } from './sideNav.utils';
import logEvent from 'api/common/logEvent';

interface UserManagementMenuItems {
key: string;
label: string;
Expand Down Expand Up @@ -179,6 +180,7 @@ function SideNav({
};

const onClickShortcuts = (e: MouseEvent): void => {
// eslint-disable-next-line sonarjs/no-duplicate-string
logEvent('Sidebar: Menu clicked', {
menuRoute: '/shortcuts',
menuLabel: 'Keyboard Shortcuts',
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/container/TimeSeriesView/TimeSeriesView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ function TimeSeriesView({
!isLoading &&
!isError &&
isFilterApplied && (
<EmptyLogsSearch dataSource={dataSource} panelType={'TIME_SERIES'} />
<EmptyLogsSearch dataSource={dataSource} panelType="TIME_SERIES" />
)}

{chartData &&
Expand Down
11 changes: 5 additions & 6 deletions frontend/src/pages/SaveView/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
TableProps,
Typography,
} from 'antd';
import logEvent from 'api/common/logEvent';
import {
getViewDetailsUsingViewKey,
showErrorNotification,
Expand All @@ -30,7 +31,7 @@ import {
Trash2,
X,
} from 'lucide-react';
import { ChangeEvent, useEffect, useState } from 'react';
import { ChangeEvent, useEffect, useRef, useState } from 'react';
import { useTranslation } from 'react-i18next';
import { useSelector } from 'react-redux';
import { useLocation } from 'react-router-dom';
Expand All @@ -43,9 +44,6 @@ import { USER_ROLES } from 'types/roles';

import { ROUTES_VS_SOURCEPAGE, SOURCEPAGE_VS_ROUTES } from './constants';
import { deleteViewHandler } from './utils';
import { isUndefined } from 'lodash-es';
import { useRef } from 'react';
import logEvent from 'api/common/logEvent';

const allowedRoles = [USER_ROLES.ADMIN, USER_ROLES.AUTHOR, USER_ROLES.EDITOR];

Expand Down Expand Up @@ -149,17 +147,18 @@ function SaveView(): JSX.Element {
const logEventCalledRef = useRef(false);
useEffect(() => {
if (!logEventCalledRef.current && !isLoading) {
if (sourcepage == DataSource.TRACES) {
if (sourcepage === DataSource.TRACES) {
logEvent('Traces Views: Views visited', {
number: viewsData?.data.data.length,
});
} else if (sourcepage == DataSource.LOGS) {
} else if (sourcepage === DataSource.LOGS) {
logEvent('Logs Views: Views visited', {
number: viewsData?.data.data.length,
});
}
logEventCalledRef.current = true;
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [viewsData?.data.data, isLoading]);
const onUpdateQueryHandler = (): void => {
updateViewAsync(
Expand Down

0 comments on commit 91c081b

Please sign in to comment.