Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect stepInterval for builder queries #4943

Closed
srikanthccv opened this issue Apr 30, 2024 · 4 comments · Fixed by #5040
Closed

Incorrect stepInterval for builder queries #4943

srikanthccv opened this issue Apr 30, 2024 · 4 comments · Fixed by #5040
Assignees
@vikrantgupta25
Labels
bug Something isn't working

Comments

@srikanthccv
Copy link
Member

Bug description

How to reproduce?

  • Open any dashboard
  • Change the time range to 1 day or 3 days
  • Look at the stepInterval value for each builder query.

Expected behavior

The stepInterval should be dynamically adjusted based on the time selected but the value is always sent 60.
@vikrantgupta25 vikrantgupta25 mentioned this issue Apr 30, 2024
Merged
@srikanthccv srikanthccv mentioned this issue May 1, 2024
Merged
@srikanthccv srikanthccv added the bug Something isn't working label May 21, 2024
@ankitnayan
Copy link
Collaborator

can this be closed?

@srikanthccv
Copy link
Member Author

It was reverted from the frontend side here #4955. To solve the issue I modified the query service to adjust the step. I would like to see this get fixed so what is shown to the user reflects the same as the actual step interval applied.

@vikrantgupta25
Copy link
Collaborator

yes this was reverted due to another issue the fix was causing, will fix this and close soon.

@vikrantgupta25 vikrantgupta25 mentioned this issue May 21, 2024
Merged
@vikrantgupta25
Copy link
Collaborator

raised the fix for this here #5040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vikrantgupta25 vikrantgupta25

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: step interval not getting updated on time range change SigNoz/signoz
3 participants
@ankitnayan @srikanthccv @vikrantgupta25