-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: logs pipelines cover all available processors with tests #4454
Chore: logs pipelines cover all available processors with tests #4454
Conversation
WalkthroughThe recent updates streamline the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 8
Configuration used: CodeRabbit UI
Files selected for processing (2)
- pkg/query-service/app/logparsingpipeline/preview_test.go (3 hunks)
- pkg/query-service/app/logparsingpipeline/processors_test.go (1 hunks)
Files skipped from review due to trivial changes (1)
- pkg/query-service/app/logparsingpipeline/preview_test.go
49ed764
to
fd2de13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- pkg/query-service/app/logparsingpipeline/preview_test.go (3 hunks)
- pkg/query-service/app/logparsingpipeline/processors_test.go (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- pkg/query-service/app/logparsingpipeline/preview_test.go
- pkg/query-service/app/logparsingpipeline/processors_test.go
…processors-with-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- pkg/query-service/app/logparsingpipeline/processors_test.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- pkg/query-service/app/logparsingpipeline/processors_test.go
…processors-with-tests
Summary
Adds an explicit happy case test for each pipeline processor that doesn't already have one.
This is in preparation for the work of making pipeline collector config sync by generating transformprocessor based collector config instead of logstransformprocessor based collector config
Related Issues / PR's
Contributes towards #4444
Summary by CodeRabbit