Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for timeshift in logs #4607

Merged
merged 14 commits into from
Mar 8, 2024
Merged

feat: support for timeshift in logs #4607

merged 14 commits into from
Mar 8, 2024

Conversation

nityanandagohain
Copy link
Member

@nityanandagohain nityanandagohain commented Feb 27, 2024 •
edited
Loading

Fixes #4583

  • The runQueryBuilder checks if there is sifftBy and then modifies the start and end timestamp so that correct query is generated and caching is also properly used.
  • The applyFunction function makes sure that even though the results has shifted timestamp it is moved back to the actual timestamp so that it can be fitted in the panel.

@github-actions github-actions bot added the enhancement New feature or request label Feb 27, 2024
@nityanandagohain nityanandagohain marked this pull request as ready for review February 29, 2024 04:04
@SigNoz SigNoz deleted a comment from coderabbitai bot Feb 29, 2024
@nityanandagohain nityanandagohain marked this pull request as draft February 29, 2024 04:58
@nityanandagohain nityanandagohain marked this pull request as ready for review February 29, 2024 14:41
srikanthccv
srikanthccv reviewed Mar 1, 2024
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add couple of tests

pkg/query-service/app/http_handler.go Outdated Show resolved Hide resolved
@nityanandagohain
Copy link
Member Author

Have added the tests @srikanthccv

@nityanandagohain nityanandagohain merged commit d0d10da into develop Mar 8, 2024
11 checks passed
@nityanandagohain nityanandagohain deleted the issue_4583 branch March 8, 2024 15:42
@srikanthccv
Copy link
Member

Please get the frontend capability added as well.

@nityanandagohain nityanandagohain mentioned this pull request Mar 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LOGS[BE]: Support for timeshift in logs v3
2 participants
@nityanandagohain @srikanthccv