Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [SIG-543]: add time selection in the custom date selection #4658

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Mar 6, 2024

Summary

  • bring back the time selection in the date time picker modal in sync with the older designs

Related Issues / PR's

https://linear.app/signoz-io/issue/SIG-543/add-back-hours-minutes-seconds-to-the-new-date-time-modal

Screenshots

Screen.Recording.2024-03-11.at.1.48.56.PM.mov

Affected Areas and Manually Tested Areas

  • relative date time selection
  • custom date time selection
  • intermediate states

Copy link

github-actions bot commented Mar 6, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Mar 6, 2024
@vikrantgupta25 vikrantgupta25 changed the title feat: [SIG-543]: inital commit feat: [SIG-543]: add time selection in the custom date selection Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

2 similar comments
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review March 11, 2024 08:20
@vikrantgupta25 vikrantgupta25 merged commit 49aba4f into develop Mar 11, 2024
11 checks passed
@srikanthccv srikanthccv deleted the SIG-543 branch April 11, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants