Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [SIG-549]: bring the ts config for pre-commit hook in sync with github CI #4660

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Mar 7, 2024

Summary

  • make the pre-commit hook temp tsconfig to be in sync with the global tsconfig in terms of type definitions

Related Issues / PR's

https://linear.app/signoz-io/issue/SIG-549/make-the-typescript-temp-config-for-husky-in-sync-with-the-tsconfig

Screenshots

NA

Affected Areas and Manually Tested Areas

Copy link

github-actions bot commented Mar 7, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added bug Something isn't working chore labels Mar 7, 2024
@vikrantgupta25 vikrantgupta25 changed the title chore: fix typecheck errors for jest fix: [SIG-549]: bring the ts config for pre-commit hook in sync with github CI Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

github-actions bot commented Mar 7, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 merged commit 62af836 into develop Mar 7, 2024
11 checks passed
@YounixM YounixM deleted the fix-typecheck branch March 7, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants