feat: handled inactive tab handling by removing the display flex override #4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sagar Rajput seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
vikrantgupta25
approved these changes
Mar 15, 2024
YounixM
approved these changes
Mar 15, 2024
vikrantgupta25
pushed a commit
that referenced
this pull request
Mar 15, 2024
…ride (#4708) Co-authored-by: Sagar Rajput <[email protected]>
vikrantgupta25
pushed a commit
that referenced
this pull request
Mar 15, 2024
…ride (#4708) Co-authored-by: Sagar Rajput <[email protected]> (cherry picked from commit 0365fa5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Here
antdusesdisplay noneproperty to hide there inactive tabs, but in this case due to a css override -display flexcaused by.logs-module-containeris overriding this style and prevent the inactive tab content to hide.Related Issues / PR's
Screenshots
Screen.Recording.2024-03-15.at.12.00.31.PM.mov
Affected Areas and Manually Tested Areas