Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not move to next step if env not selected in onboarding #4784

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Apr 1, 2024

Summary

  • Block the user to move to next step if the environment is not selected
  • the selectedEnvironment was being sent as null but the isValidForm expected it to be '' instead , so added check for the same as well

Related Issues / PR's

Screenshots

Screen.Recording.2024-04-01.at.1.38.32.PM.mov

Affected Areas and Manually Tested Areas

@github-actions github-actions bot added the bug Something isn't working label Apr 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

github-actions bot commented Apr 1, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 merged commit 51abe71 into develop Apr 1, 2024
10 of 12 checks passed
@vikrantgupta25 vikrantgupta25 deleted the onboarding-env branch April 1, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants