fix: fixed sidenav alignment with and without get-started #4829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Rajat-Dabade
approved these changes
Apr 8, 2024
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
vikrantgupta25
approved these changes
Apr 10, 2024
YounixM
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we have a border on the left side of the container, it adds to the overall width of the container. Therefore, the available space for the child items to be aligned within the container is slightly reduced. By removing the border-left, we are effectively increasing the available width for the child items to be centered within the container. This change in width affects the alignment calculation, causing the child items (including the icon) to appear more centered within the container.
Related Issues / PR's
Screenshots
Get-started alignment:
undocked:
docked:
Affected Areas and Manually Tested Areas