Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: threshold getting cleared on stage and run query and user not able to create alert issue #4875

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: threshold getting cleared on stage and run query and user not able to create alert issue #4875

merged 1 commit into from
Apr 17, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Apr 17, 2024 •
edited
Loading

Summary

  • On stage and run query the parent component was triggering the change of initial value which was causing the reference to change hence the child component regained the base state
  • in the fix we do not retrigger the state update until the value updated

Related Issues / PR's

Fix - #4873

Screenshots

Screen.Recording.2024-04-17.at.3.58.22.PM.mov

Affected Areas and Manually Tested Areas

  • create alerts
  • edit alerts
  • reload
  • navigation

@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review April 17, 2024 10:25
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Apr 17, 2024
@vikrantgupta25 vikrantgupta25 changed the title fix: handle the edge cases for alerts create form fix: threshold getting cleared on stage and run query and user not able to create alert issue Apr 17, 2024
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 merged commit 48e5436 into develop Apr 17, 2024
14 of 16 checks passed
@SagarRajput-7 SagarRajput-7 mentioned this pull request May 16, 2024
Closed
@srikanthccv srikanthccv deleted the alert-threshold-fix branch June 13, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@SagarRajput-7 SagarRajput-7 SagarRajput-7 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vikrantgupta25 @YounixM @SagarRajput-7