Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: time interval not getting updated in case of edit dashboard #4940

Merged
merged 1 commit into from
May 1, 2024
Merged

fix: time interval not getting updated in case of edit dashboard #4940

merged 1 commit into from
May 1, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Apr 30, 2024 •
edited
Loading

Summary

  • global time interval changes not respected in the edit dashboard page
  • the global time range interval was not getting updated in the request data hence the time interval was not respected.

Related Issues / PR's

Screenshots

Screen.Recording.2024-04-30.at.1.18.05.PM.mov

Affected Areas and Manually Tested Areas

  • verified different time ranges and combination of different timePreferences with global time changing

@github-actions github-actions bot added the bug Something isn't working label Apr 30, 2024
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review April 30, 2024 07:49
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 force-pushed the fix-time-interval-in-edit-dashboard branch from c8ebf8c to 255ac2a Compare April 30, 2024 09:17
@vikrantgupta25 vikrantgupta25 force-pushed the fix-time-interval-in-edit-dashboard branch from 255ac2a to d4fb7ce Compare May 1, 2024 07:18
@vikrantgupta25 vikrantgupta25 merged commit b85b9f4 into develop May 1, 2024
12 checks passed
@vikrantgupta25 vikrantgupta25 deleted the fix-time-interval-in-edit-dashboard branch May 1, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@SagarRajput-7 SagarRajput-7 SagarRajput-7 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vikrantgupta25 @YounixM @SagarRajput-7