feat: show log severity indicator based on severity number if it's available when severity text is unknown #4971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raj-k-singh can we get PR #4694 merged instead and make any changes required there? |
…mber-when-unknown-sev-text
YounixM
approved these changes
Jul 25, 2024
ahmadshaheer
approved these changes
Jul 25, 2024
srikanthccv
approved these changes
Aug 1, 2024
srikanthccv
deleted the
chore/logs-color-by-sev-number-when-unknown-sev-text
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
priority is given to the severity_number when a known value is present and then the severity_text is given the preference. if both of them have unknown values then rely on the log_level if present in the attributes_string and the final fallback is INFO.
Related Issues / PR's
Fixes #4970
Before
After
Affected and tested area
Logs explorer list