Chore: restrict logs connection test for integrations to use log attributes for identifying logs #4977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith-source-attribs
srikanthccv
approved these changes
May 14, 2024
raj-k-singh
deleted the
chore/integrations-logs-connection-test-with-source-attribs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our current approach to integrations ensures that logs for an integration always have the source attribute populated.
In preparation for opening up creation of new integrations by the team internally, this change restricts logs connection test for integrations to use an attribute filter only (previously any valid log filter was allowed)
restricting logs connection tests to attributes will also allow us to seamlessly switch to using the tag_attributes table if the performance of searching the logs table isn't good enough.
Related Issues / PR's
#2760
Affected Areas and Manually Tested Areas
Integrations