Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add AWS RDS and ElastiCache integration #5071

Merged
merged 14 commits into from
Jun 2, 2024
Merged

Conversation

srikanthccv
Copy link
Member

Summary

Related to #4673

@github-actions github-actions bot added the chore label May 24, 2024
@srikanthccv srikanthccv marked this pull request as ready for review May 28, 2024 14:20
Copy link
Collaborator

@raj-k-singh raj-k-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments.

I am yet to try following the instructions for the integrations. Will try and get that done today/tomorrow

raj-k-singh
raj-k-singh previously approved these changes May 31, 2024
Copy link
Collaborator

@raj-k-singh raj-k-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more minor comments

LGTM 👍

@srikanthccv srikanthccv merged commit 592073a into develop Jun 2, 2024
12 checks passed
@srikanthccv srikanthccv deleted the aws-integration branch June 2, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants