Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clone dashboard panel intermittent issue #5096

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: clone dashboard panel intermittent issue #5096

merged 1 commit into from
May 29, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented May 28, 2024

Summary

  • onCloneDashboardHandler did not update the local state after the PUT call hence the editor page didn't receive the data and hence displayed the base state.
  • added state updates on success of the PUT call
  • this was occurring intermittently as there happens a get call in the widget editor which is succeeds before state setting it worked as expected.

Related Issues / PR's

Screenshots

Screen.Recording.2024-05-28.at.11.39.48.AM.mov

Affected Areas and Manually Tested Areas

  • clone dashboard handlers

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label May 28, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@YounixM YounixM merged commit c913c8b into develop May 29, 2024
11 of 13 checks passed
@vikrantgupta25 vikrantgupta25 deleted the clone-panel branch May 29, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants