Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: random sizing issue with alerts query builder #5116

Merged
merged 5 commits into from
May 31, 2024
Merged

fix: random sizing issue with alerts query builder #5116

merged 5 commits into from
May 31, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented May 30, 2024 •
edited
Loading

Summary

  • global styles getting overriden for options class
  • make ant-picker component and popover to be displayed in modals and drawers. ( z-index )

Related Issues / PR's

fixes https:/SigNoz/engineering-pod/issues/1322

Screenshots

NA

Affected Areas and Manually Tested Areas

@github-actions github-actions bot added the bug Something isn't working label May 30, 2024
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review May 31, 2024 06:17
@vikrantgupta25 vikrantgupta25 changed the title fix: alerts qb rendering fix: random sizing issue with alerts query builder May 31, 2024
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

2 similar comments
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

SagarRajput-7
SagarRajput-7 previously approved these changes May 31, 2024
View reviewed changes
YounixM
YounixM reviewed May 31, 2024
View reviewed changes
frontend/src/styles.scss Outdated Show resolved Hide resolved
@YounixM
Copy link
Member

YounixM commented May 31, 2024 •
edited
Loading

Elements with z-index

  1. Tooltip
  2. Popover
  3. Modal
  4. Drawer
  5. Dropdown
  6. TimePicker
  7. Notification
  8. Popconfirm

@vikrantgupta25 vikrantgupta25 merged commit ba0f63a into develop May 31, 2024
12 checks passed
@vikrantgupta25 vikrantgupta25 deleted the alerts-fix branch May 31, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@SagarRajput-7 SagarRajput-7 SagarRajput-7 left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vikrantgupta25 @YounixM @SagarRajput-7