Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: page jumping for alerts #5119

Merged
merged 1 commit into from
May 31, 2024
Merged

fix: page jumping for alerts #5119

merged 1 commit into from
May 31, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented May 31, 2024

Summary

  • the page randomly jumps around when the stage and run is clicked
  • this happens because the loader was being rendered and it occupied a fix height of 70vh and got removed as soon as data comes thus shifting up and down by 70vh
  • rendered the loader inside the data component so either of the two renders hence no jumping

Related Issues / PR's

fixes https:/SigNoz/engineering-pod/issues/1318

Screenshots

Screen.Recording.2024-05-31.at.12.19.05.PM.mov

Affected Areas and Manually Tested Areas

@github-actions github-actions bot added the bug Something isn't working label May 31, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 merged commit 6aded04 into develop May 31, 2024
11 of 13 checks passed
@vikrantgupta25 vikrantgupta25 deleted the page-jumping-alerts branch May 31, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants