Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: table sorting when units are present #5249

Merged
merged 1 commit into from
Jun 17, 2024
Merged

fix: table sorting when units are present #5249

merged 1 commit into from
Jun 17, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Jun 17, 2024 •
edited
Loading

Summary

  • when adding units to any column add another data column with label label_without_unit which helps us in sorting
  • and when sorting if there is a column present with without_unit use that else use the normal column

Related Issues / PR's

Screenshots

Screen.Recording.2024-06-17.at.2.33.05.PM.mov

Affected Areas and Manually Tested Areas

  • table panel type with and without units

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Jun 17, 2024
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review June 17, 2024 09:04
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 merged commit 2a4e97f into develop Jun 17, 2024
10 of 15 checks passed
@vikrantgupta25 vikrantgupta25 deleted the table-sorting branch June 17, 2024 10:21
@srikanthccv srikanthccv mentioned this pull request Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vikrantgupta25 @YounixM @srikanthccv