chore: threshold rule panel type to graph #5284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We only support line chart panel type in alerts i.e. the result of the query should be n number of points for series and the condition is evaluated against it. The other panel type creates an invalid query for logs/traces as seen in customer env https://signoz-team.slack.com/archives/C02C7P6KE06/p1714633414469399?thread_ts=1714619780.164229&cid=C02C7P6KE06. This ensures alert queries will not produce invalid queries even if they were misconfigured from the API and give additional bandwidth to #5219
so that it can be fixed properly.