Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added empty states for list, trace and timeSeried view in traces #5290

Merged
merged 8 commits into from
Jul 8, 2024

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Jun 19, 2024

Summary

Related Issues / PR's

Screenshots

List view -

Screenshot 2024-06-20 at 1 25 47 AM
Screenshot 2024-06-20 at 1 25 59 AM

Traces view -

image
image

Time series -

image
image

Cloud User -

Screen.Recording.2024-06-20.at.1.31.02.AM.mov

Non-cloud user -

Screen.Recording.2024-06-20.at.1.31.49.AM.mov

Affected Areas and Manually Tested Areas

@github-actions github-actions bot added the enhancement New feature or request label Jun 19, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

4 similar comments
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7 SagarRajput-7 force-pushed the SIG-1397 branch 2 times, most recently from 5c719b1 to 68a86d3 Compare June 21, 2024 06:20
YounixM
YounixM previously approved these changes Jun 21, 2024
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the utm comment

@SagarRajput-7
Copy link
Contributor Author

please check the utm comment

This was an existing link and code section. I have started talking with @makeavish about generating a link for this with the UTM parameter, but it seems like we might have to add a new link also to the doc.

@SagarRajput-7
Copy link
Contributor Author

@makeavish - can you please help with the ETA for the new link with UTM parameters, or can we go ahead with this PR if that will take time.
Thanks!

@makeavish
Copy link
Member

@makeavish - can you please help with the ETA for the new link with UTM parameters, or can we go ahead with this PR if that will take time. Thanks!

Here's the link: https://signoz.io/docs/product-features/trace-explorer/?utm_source=product&utm_medium=traces-explorer-trace-tab#traces-view
Only for below section:

image

vikrantgupta25
vikrantgupta25 previously approved these changes Jun 26, 2024
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SagarRajput-7 SagarRajput-7 merged commit c9309ee into develop Jul 8, 2024
11 of 12 checks passed
@SagarRajput-7 SagarRajput-7 deleted the SIG-1397 branch July 8, 2024 05:49
@vikrantgupta25
Copy link
Collaborator

marking the issue here as well :- https://signoz-team.slack.com/archives/C05PB7EN2HL/p1720504276670169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants