chore: add start/end millis for trace details response #5321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makeavish
approved these changes
Jun 24, 2024
makeavish
reviewed
Jun 24, 2024
| @@ -1983,6 +1993,9 @@ func (r *ClickHouseReader) SearchTraces(ctx context.Context, params *model.Searc | |||
| } | |||
| } | |||
|
|
|||
| searchSpansResult[0].StartTimestampMillis = startTime - durationNano | |||
There was a problem hiding this comment.
@srikanthccv Here we should have converted durationNano to milliseconds before subtracting or adding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #5049
Since the
traceIDis part of the path var, I assume it will always be there and the resultsearchSpansResultwill contain exactly one item as initialized heresignoz/pkg/query-service/app/clickhouseReader/reader.go
Line 1943 in a7a160d
signoz/ee/query-service/app/db/trace.go
Line 120 in a7a160d
We go through all the items scanned into
searchScanResponsesand send themin(timestamp) - durationNanoas start andmax(timestamp) + durationNanoas end. The start and end are not exact but they serve the purpose.