fix: added null check on filters obj #5419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
SagarRajput-7
force-pushed
the
sentry-issue
branch
from
289972d
to
62e962a
Compare
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
YounixM
approved these changes
Jul 10, 2024
ahmadshaheer
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added test cases also for undefined filter and items
Related Issues / PR's
https://signoz-io.sentry.io/issues/5565889237/events/5d9b8c616fbd4924a77daa060f5da283/?project=4506831143763968&referrer=alert-rule-issue-list
Screenshots
NA
Affected Areas and Manually Tested Areas