Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resize observer charts issue in alerts builder #5436

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Jul 5, 2024

Summary

  • the div where the graph ref is being attached was conditionally rendered if the error is present or not hence causing the resize observer to not calculate the dimensions properly.

Related Issues / PR's

fixes https:/SigNoz/engineering-pod/issues/1355

Screenshots

Screen.Recording.2024-07-05.at.4.45.36.PM.mov

Affected Areas and Manually Tested Areas

Copy link

github-actions bot commented Jul 5, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Jul 5, 2024
@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review July 5, 2024 11:15
Copy link

github-actions bot commented Jul 5, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

github-actions bot commented Jul 5, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 merged commit bf17788 into develop Jul 8, 2024
11 of 14 checks passed
@vikrantgupta25 vikrantgupta25 deleted the resize-observer-alerts-issue branch July 8, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants