Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retain legends while changing panel types #5447

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Jul 8, 2024

Summary

  • the panel type vs datasource map was missing legends property hence not picking up the same from superset query.
  • the histogram panel was missing for disabled property as well. added the same.

Related Issues / PR's

fixes https:/SigNoz/engineering-pod/issues/1449

Screenshots

NA

Affected Areas and Manually Tested Areas

Copy link

github-actions bot commented Jul 8, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review July 8, 2024 10:00
@vikrantgupta25 vikrantgupta25 merged commit c7e3e6d into develop Jul 15, 2024
11 of 12 checks passed
@vikrantgupta25 vikrantgupta25 deleted the fix-retain-legends-while-panel-change branch July 15, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants