Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule maintainence release changes #5585

Merged
merged 9 commits into from
Jul 31, 2024

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Jul 28, 2024

Summary

Fixes done -

  • Repeats every feels like text box with cursor blinking. And doesn't close on hover out. Overall bad UX.
  • Search for alert doesn't work
  • Duration should not accept negative values
  • Write a note that says "Leave empty to silence all alerts". UI should accept and send empty array as request payload to silence all alerts
  • In recurrence schedule, the start and end are incorrectly saved & displayed without timezone considerations. They appear to not use the "recurrence" object values. Also the start and end are different in the "schedule" object and "schedule.recurrence" object
  • Mark which fields are mandatory
    • Name, start and timezone are always mandatory
    • End is mandatory if the schedule is fixed
    • If the schedule is recurring
    • end is optional
    • duration is mandatory
  • "1h30m" should be "90m" instead of "1h"
  • Doesn't send repeat type for recurrence schedule edit.
  • Delete window says "view" instead of "schedule"
  • Timezone consideration for starttime and endtime

Tested P0s -

fixed:

  • New
    • changed timezone
  • Edit
    • changed timezone

Recuring:

  • New
    • changed timezone
    • daily
    • weekly
    • monthly
    • with end time
    • without end time
  • Edit
    • changed timezone
    • daily
    • weekly
    • monthly
    • with end time
    • without end time

Related Issues / PR's

Screenshots

Screen.Recording.2024-07-28.at.9.29.34.PM.mov

Affected Areas and Manually Tested Areas

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7 SagarRajput-7 force-pushed the schedule-maintainence-release-changes branch from 0cf73d4 to 3e6e2de Compare July 29, 2024 04:52
@srikanthccv srikanthccv self-assigned this Jul 29, 2024
@srikanthccv
Copy link
Member

  1. For recurring schedules, Timeframe and Repeats show different time values. This is because the payload is incorrect for the recurring schedule. Example payload frontend is sending for schedule from 29th July 2:40 to 31st July 2:40
{
  "alertIds": [
    "66"
  ],
  "name": "daily recurrence with end time",
  "schedule": {
    "startTime": "2024-07-29T14:40:00Z",
    "timezone": "Asia/Kolkata",
    "endTime": "2024-07-31T14:40:00Z",
    "recurrence": {
      "duration": "2h",
      "endTime": "2024-07-31T09:10:00.572Z",
      "startTime": "2024-07-29T09:10:00.221Z",
      "repeatType": "daily"
    }
  }
}

Screenshot 2024-07-29 at 2 25 22 PM

  1. For recurring schedules with end time defined, in edit mode, Repeats every shows Does not repeat and saving it makes the schedule fixed one and erases the recurring data.

Screenshot 2024-07-29 at 2 45 16 PM

  1. To be consistent with the rest of the product, order the list items by updated time.

@SagarRajput-7 SagarRajput-7 force-pushed the schedule-maintainence-release-changes branch from 824d7d0 to 7d9fc7a Compare July 29, 2024 11:11
@SagarRajput-7 SagarRajput-7 force-pushed the schedule-maintainence-release-changes branch from 6f486cb to 268a0a6 Compare July 31, 2024 05:52
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7
Copy link
Contributor Author

FIxed all the above issues

Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, All the issues mentioned above and the cases shared are working

@SagarRajput-7 SagarRajput-7 merged commit fff9954 into develop Jul 31, 2024
11 of 12 checks passed
@SagarRajput-7 SagarRajput-7 deleted the schedule-maintainence-release-changes branch July 31, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants