Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not send query_range api call on every keystroke #5613

Merged
merged 2 commits into from
Jul 31, 2024
Merged

fix: do not send query_range api call on every keystroke #5613

merged 2 commits into from
Jul 31, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Jul 31, 2024 •
edited
Loading

Summary

  • in the update function of handleSetQueryData the prop reference was getting updated hence the stagedQuery got updated and the api calls triggered.

Related Issues / PR's

fixes #5591

Screenshots

NA

Affected Areas and Manually Tested Areas

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Jul 31, 2024
@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review July 31, 2024 11:26
@YounixM YounixM merged commit 220edd1 into develop Jul 31, 2024
11 of 12 checks passed
@srikanthccv srikanthccv deleted the api-every-keystroke branch September 12, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@ahmadshaheer ahmadshaheer ahmadshaheer approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not send request on every key stroke without selecting the aggregate attribute
3 participants
@vikrantgupta25 @YounixM @ahmadshaheer