fix: make timeshift work with cache #5646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
nityanandagohain
previously approved these changes
Aug 6, 2024
vikrantgupta25
previously approved these changes
Aug 6, 2024
srikanthccv
dismissed stale reviews from vikrantgupta25 and nityanandagohain
via
90e9394
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
nityanandagohain
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Let's say we have two builder queries, A and B. They're configured exactly the same, except B is shifted by one day back. Without accounting for this time shift in the cache key, query B would end up using A's cached values, leading to incorrect results. This change addresses that issue.